fix hanging tests caused by legacy rsvp code #20210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! @rwjblue can you take a gander, as the person with (I think) the most context here? Also, @patricklx if you update (via rebase or merge), the type checking issue should be resolved now. |
|
Now you have actual type and test failures. 😉 |
|
I tried rebasing but I can't push to @patricklx's remote. Do you have some time @patricklx? |
|
Hi @locks , sure. I totally forgot about this. It looks like it's still not fixed on qunit side... |
this causes tests to hang when a RSVP promise gets rejected. causes by qunitjs/qunit#1705 fixes emberjs/ember-qunit#476
NullVoxPopuli
approved these changes
Aug 9, 2023
patricklx
changed the title
wagenet
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
@NullVoxPopuli assures me this is fine. I'll throw him under the bus if there are issues 😉
|
I accept these conditions :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should be legacy code?
this causes tests to hang when a RSVP promise gets rejected. E.g visit helper route reject
causes by qunitjs/qunit#1705
fixes emberjs/ember-qunit#476