Integrate types for the warn method
#20224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
requested changes
Oct 27, 2022
|
@emberjs/typescript-core is this relevant? |
It should be OK to merge with @chriskrycho's suggestions. |
gitKrystan
approved these changes
Dec 13, 2023
Mention the `id` parameter in the options object.
Co-authored-by: Chris Krycho <hello@chriskrycho.com>
wagenet
approved these changes
Jan 10, 2024
|
I rebased and it turns out we'd already integrated most of the changes in other PRs. That said, there are some documentation improvements here that we could merge in. |
|
Enabled auto-merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consist of two commits (if they are okay, I can them squash them)
idproperty in the options object of thewarnmethod. Thedeprecatemethod mentions the sub-options properties and I tried to align the doc's for the warn method.warnmethod. Right now, thetestparameter can be used as atest-condition or as a shortcut for theoptionsobject to always display the warning. Theoptionsobject itself is required for the warning.What do you think?