[CLEANUP] Make intern utility type safe
#20268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimenting with removing/improving some *other* types while implementing RFC 0821. revealed that this function needed to preserve its input type when that type was narrower than just `string`, so introduce a type parameter to keep that information around. Then, switch to using `Object.create(null)` so it can be used in the `Record` type safely. Pulling this out into its own commit makes it easier to land, and it also allows us to guarantee that we are making changes *only* to the types and module layout for the PR implementing RFC 0821.
jamescdavis
reviewed
Nov 16, 2022
jamescdavis
approved these changes
Nov 16, 2022
chriskrycho
changed the title
intern utility type safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with removing/improving some other types while implementing RFC 0821. revealed that this function needed to preserve its input type when that type was narrower than just
string, so introduce a type parameter to keep that information around. Then, switch to usingObject.create(null)so it can be used in theRecordtype safely.Pulling this out into its own commit makes it easier to land, and it also allows us to guarantee that we are making changes only to the types and module layout for the PR implementing RFC 0821.