Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the @ember/error package internally and improve types #20298

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

wagenet
Copy link
Member

@wagenet wagenet commented Dec 6, 2022

This package just re-exports the native Error class. We should remove it entirely, but in the meantime, stop using it internally.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 ship it.

@wagenet
Copy link
Member Author

wagenet commented Dec 6, 2022

See also DefinitelyTyped/DefinitelyTyped#63511

@wagenet wagenet enabled auto-merge December 6, 2022 17:23
@wagenet wagenet merged commit d19d210 into emberjs:master Dec 6, 2022
@wagenet wagenet deleted the no-ember-error branch December 6, 2022 17:39
@chriskrycho chriskrycho added internal TypeScript Work on Ember’s types labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants