Upgrade to ember-cli-babel 8.2.0 #20557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandfresh
approved these changes
Oct 16, 2023
|
Is this still relevant? It is a draft PR |
|
oh probably, I should rebase |
|
and convert from draft, if you want it merged :) |
NullVoxPopuli
force-pushed
the
patch-2
branch
from
01a06b6 to
23553c5
Compare
NullVoxPopuli
commented
Dec 12, 2023
There was a problem hiding this comment.
looks like lints don't enforce sort order here -- leaving tooling to mess things up.....
|
Yeah, I am not sure what is the answer to your questions (basically: would it have been a breaking change if we required a new peer dependency?). I did write in my commit message that, if we couldn’t upgrade easily, I only needed the static block plugin so I could also configure that directly |
|
But if we are going to do that, feel free to land it here and I’ll rebase when it’s available. I don’t necessarily think that other branch is intended for direct merging anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-cli-babel 8 includes nice things for supporting
content-tag.Ideally, however, once ember-source is a v2 addon, we can just remove ember-cli-babel.
The breaking change from ember-cli-babel 7 to 8: https://github.com/emberjs/ember-cli-babel/releases/tag/v8.0.0
is that the consuming project must have declared
@babel/core, which is already in the blueprint: https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json#L29(but was not added until ember-cli 5.3).
So, does this mean that ember-source can't upgrade ember-cli-babel?
and instead should convert to v2 addon? (I'm thinking it does).
However, this needs finished, but I don't know what's going on anymore.