Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Deprecate outlet TemplateFactory support #20578

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

chancancode
Copy link
Member

Backport of #20577

The exact code itself will probably apply cleanly to LTS as well. Logistically I'm not sure if we need to bother. We probably want to release emberjs/ember-test-helpers#1445 before merging this into the next beta, so people have something to upgrade to.

@chancancode
Copy link
Member Author

Fix is merged upstream, pending release

@chancancode
Copy link
Member Author

Upstream fix has been released in @ember/test-helpers v3.2.1, I re-ran the failing ember-try scenario locally on embroider-css-modules (where @ijlee2 first noticed and reported the problem) and confirmed that 1) it passes with deprecation on canary 2) it passes with no deprecations with the latest @ember/test-helpers. So I think we are good to go.

@kategengler do I update the available/enabled field on canary after this goes out with beta?

@chancancode chancancode merged commit 7694ed0 into beta Nov 20, 2023
18 checks passed
@chancancode chancancode deleted the beta-deprecate-outlet-template-factory branch November 20, 2023 04:05
@ijlee2
Copy link
Member

ijlee2 commented Nov 20, 2023

Upstream fix has been released in @ember/test-helpers v3.2.1, I re-ran the failing ember-try scenario locally on embroider-css-modules (where @ijlee2 first noticed and reported the problem) and confirmed that 1) it passes with deprecation on canary 2) it passes with no deprecations with the latest @ember/test-helpers. So I think we are good to go.

@kategengler do I update the available/enabled field on canary after this goes out with beta?

@chancancode Thanks for looking into the issue and releasing a patch for @ember/test-helpers.

In ijlee2/embroider-css-modules#120, I confirmed that updating @ember/test-helpers to v3.2.1 allows me to remove the ember-try configuration allowedToFail: true for ember-canary scenarios.

https://github.com/ijlee2/embroider-css-modules/actions/runs/6926965437/job/18839976721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants