Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP canary] Remove final eager consumption of AMD loader #20620

Merged
merged 1 commit into from
Jan 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/ember/index.ts
Original file line number Diff line number Diff line change
@@ -506,8 +506,10 @@ namespace Ember {
get define() {
return (globalThis as any).define;
},
// @ts-expect-error These properties don't appear as being defined
registry: typeof requirejs !== 'undefined' ? requirejs.entries : require.entries,
get registry() {
let g = globalThis as any;
return g.requirejs?.entries ?? g.require.entries;
},
};

// ------------------------------------------------------------------------ //

Unchanged files with check annotations Beta

export interface ContainerOptions {
owner?: InternalOwner;
cache?: { [key: string]: object };
factoryManagerCache?: { [key: string]: InternalFactoryManager<any, any> };

Check warning on line 59 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Unexpected any. Specify a different type

Check warning on line 59 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Unexpected any. Specify a different type
validationCache?: { [key: string]: boolean };
}
*/
ownerInjection() {
let injection = {};
setOwner(injection, this.owner!);

Check warning on line 207 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Forbidden non-null assertion
return injection;
}
}
if (DEBUG) {
Container._leakTracking = leakTracking!;

Check warning on line 236 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Forbidden non-null assertion
}
/*
},
};
return new Proxy(proxiedManager, validator as any) as any;

Check warning on line 267 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Unexpected any. Specify a different type

Check warning on line 267 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Unexpected any. Specify a different type
}
function isSingleton(container: Container, fullName: FullName) {
// if this lookup happened _during_ destruction (emits a deprecation, but
// is still possible) ensure that it gets destroyed
if (container.isDestroying) {
if (typeof (instance as any).destroy === 'function') {

Check warning on line 399 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Unexpected any. Specify a different type
(instance as any).destroy();

Check warning on line 400 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Unexpected any. Specify a different type
}
}
let value = cache[key];
assert('has cached value', value);
if ((value as any).destroy) {

Check warning on line 431 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Unexpected any. Specify a different type
(value as any).destroy();

Check warning on line 432 in packages/@ember/-internals/container/lib/container.ts

GitHub Actions / Linting

Unexpected any. Specify a different type
}
}
}