[BUGFIX beta] Make sure the component-class blueprint generates a signature in a TS project
#20645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
reviewed
Feb 7, 2024
blueprints/-utils.js
Outdated
| ` Element: null;`; | ||
|
|
||
| return ( | ||
| `interface ${componentName}Signature {${EOL}` + |
There was a problem hiding this comment.
Generally the guidance we've given with Glint is to always export your signature, since it's useful when you start talking about places where other components are yielding or or accepting this one as an arg.
There was a problem hiding this comment.
Thanks @dfreeman. Updated accordingly.
bertdeblock
force-pushed
the
fix-component-class-blueprint-in-ts-project
branch
from
632a6ce
to
a362683
Compare
|
Thank you! |
kategengler
changed the title
component-class blueprint generates a signature in a TS projectcomponent-class blueprint generates a signature in a TS project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20598.