Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all tests with all deprecations enabled, and with them at the default state for the version #20668

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Run all tests with all deprecations enabled, and with them at the default state for the version #20668

merged 2 commits into from
Mar 26, 2024

Conversation

kategengler
Copy link
Member

  • Create a listing of deprecations that should be used as the source of truth for deprecations issued by Ember itself
  • Convention to pass the test/isEnabled to deprecate/expectDeprecation so that our testing mechanism will work

@kategengler
Run all tests with all deprecations enabled, and with them at the
98af2cd 
default state for the version

- Create a listing of deprecations that should be used as the source of
  truth for deprecations issued by Ember itself
- Convention to pass the test/isEnabled to deprecate/expectDeprecation
  so that our testing mechanism will work
NullVoxPopuli
NullVoxPopuli reviewed Mar 26, 2024
View reviewed changes
packages/@ember/-internals/deprecations/index.ts
isEnabled: isEnabled(options),
};
}
export const DEPRECATIONS = {
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be tricky when it comes to me generating the list of things to deprecate for 'ember' -- maybe I'll codemod it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the same list you needed to generate previously, but now will all be referenced from one location. The message can still vary by location used (and is expected to do so).

@kategengler
Document new deprecations convention
7105a4b 
- Updates to CONTRIBUTING.md
@kategengler kategengler merged commit b4c4067 into main Mar 26, 2024
21 checks passed
@kategengler kategengler deleted the kg-test-enabled-disabled-deprecations branch March 26, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kategengler @NullVoxPopuli