[BUGFIX release] Remove unintentional duplication from ember-testing bundle #20726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef4
force-pushed
the
extra-content-in-testing
branch
from
7bbd411
to
cb17142
Compare
NullVoxPopuli
approved these changes
Aug 5, 2024
| get VERSION() { return require('ember/version').default }, | ||
| }, | ||
| }`, | ||
| '@ember/-internals/glimmer': `{ |
There was a problem hiding this comment.
are these stubs that don't matter / aren't used in the actual output?
There was a problem hiding this comment.
They're used in the ember-template-compiler.js bundle. Which has always done wonky things so that it will share the main ember implementations of things if you load it into the browser, but bring its own copies of some of the things and stub the others if you load it by itself in node.
There was a problem hiding this comment.
The node tests accurately reflect the things that older versions of ember-cli-htmlbars actually expect the ember-template-compiler.js bundle to do.
|
@kategengler this is ready and should be "bugfix release". |
kategengler
changed the title
kategengler
approved these changes
Aug 5, 2024
This was referenced Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on a fix for #20724
The ember-testing bundle is inlining copies of other ember packages that cause state to duplicate, which is most noticeable in breaking legacy test waiters.