Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] importing ember-source/types no longer works (it should) #20792

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Nov 12, 2024

Resolves: #20789

Which allows folks to use:

import 'ember-source/types';

in some ts file.

or

types: ['ember-source/types']

in tsconfig.json

Tested locally:
image
image

And one additional error state (which is reality before this PR)
image

@kategengler
Copy link
Member

You tagged this release -- does it affect 6.0 or only 6.1?

@kategengler kategengler requested a review from ef4 November 12, 2024 16:24
@NullVoxPopuli
Copy link
Contributor Author

It does affect 6.0, yes

@kategengler kategengler merged commit 1a63242 into emberjs:main Nov 12, 2024
24 checks passed
@NullVoxPopuli NullVoxPopuli deleted the fix-types branch November 12, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In 6.1-alpha, importing ember-source/types doesn't work, but the types: [] method does
3 participants