Failing test for comparing two properties

[mehulkar]

It would be nice to be able to have a computed property for comparing two dependent keys.

[bradleypriest]

There is https://github.com/jamesarosen/ember-cpm, but I agree, this would be nice in ember-core.
This is what I add to all my projects

Ember.computed.boundEqual = function(first, second) {
  return Ember.computed(first, second, function(key, value) {
    return get(this, first) === get(this, second);
  });
};

[stefanpenner]

@bradleypriest a bound equal or similar, should likely enumerate equality checks across all arguments.

allEqual: Ember.computed.boundEquals('for','bar','baz')

I would assume one of the barriers to getting it in, is proper naming.

[mehulkar]

@stefanpenner, agreed, I couldn't think of a better name. Em.computed.equal seemed appropriate, but that's already used for something else. I can make a failing test cases for n keys as well, but I wasn't able to use registerComputed to make the tests pass.

[twokul]

It might sound a little radical but I would route for having a separate official CP library with CPs as boundEquals (to make core lighter).

[hjdivad]

@twokul this will be completely unnecessary if we get composable cps in. Then you just have Em.computed.get to distinguish bound from string values.

[twokul]

@hjdivad fair enough

[mehulkar]

@hjdivad what do you mean by composable CPs? Is there a discussion on this somewhere? It sounds awesome

[twokul]

@mehulkar we're working on them. We hope to submit a PR + open discourse discussion soon-ish.

[mehulkar]

Very nice. Let me know if I can be useful

[wagenet]

I think we're going to work hard to get composable CPs in so I'm going to assume that it will be covered there. @mehulkar If you want to provide any review or feedback on that PR, that would be great. Thanks!

[mehulkar]

Will do, thanks @wagenet !