Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING BUGFIX] Do not assume null Ember.get targets are all globals #3852

Merged
merged 1 commit into from
Mar 8, 2015

Commits on Mar 8, 2015

  1. [BREAKING BUGFIX] Do not assume null Ember.get targets are all globals

    * Changes globals to only mean properties starting with $ or a capital letter.
    * Changes normalizeTuple(obj, 'Foo') to resolve Foo as a global. This
      makes the behavior consistent with normalizeTuple(obj, 'Foo.bar') which
      already resolves Foo as a global (and looks up bar).
    * Changes normalizeTuple(null, 'Foo') to resolve Foo as a global.
    * Specs normalizeTuple('null', 'foo') to resolve to [undefined, '']. This
      is unfortunate but needed to keep getPath happy.
    
    This code is old, and tricky to modify due to perf optimizations and
    edge case behavior. It would be great to refactor more heavily at some
    other date. I've spec'd out more of the current behavior and edge cases
    in this commit.
    
    Fixes emberjs#3760
    mixonic committed Mar 8, 2015
    Configuration menu
    Copy the full SHA
    1a3dde2 View commit details
    Browse the repository at this point in the history