[FEATURE Beta] Benchmarks #3903
Conversation
|
|
|
Wow! It would be great to have an indicator of overall perf difference (percentage). I do this with smth like this. To get a handle on the overage perf increase/decrease as ops/sec can be hard read into: |
|
@jdalton good catch, adding to the list |
|
@twokul - Great job on this, it looks good. I'll try to check it out in more detail later, but here are some initial observations:
|
This PR introduces benchmarks for Ember.js. Originally, it came out of [Composable CP PR](#3696). Benchmarks are powered by ES6 modules, grunt and [benchmark.js](http://benchmarkjs.com/). TODOs: - [x] Benchmarks run in the browser - [ ] Benchmarks run in the command line - [x] Grunt should pick up different version of Ember.js automatically (right now benchmarks run against two versions of Ember.js) - [ ] Output results of the benchmarks - [x] Add README - [ ] Add more benchmark tests (real life scenarios) - [ ] Leverage [ember-performance](https://github.com/eviltrout/ember-performance) tests - [ ] Use [bower](http://bower.io/) for dependency management
|
I am curious what others have to say, but I really like being able to run the test suite offline. Fwiw. |
|
@mixonic - Yeah, @twokul and I talked a bit more about it, and came to that same conclusion. My only objection is storing the actual assets in the repo, but that is easily solved by either bower or NPM. I do think that having a simple way to pull the comparisons from the published builds makes a lot of sense, but it should still be possible to generate your own comparison locally.... |
|
👍 👍 you guys are great. |
|
Really nice stuff. The awesome followup will be ember-dev building a graph of operation perf / time (commit). |
|
@hjdivad - Definitely on the TODO list once this is finished… |
| benchmarks = {}; | ||
|
|
||
| window.addEventListener('message', function(event) { | ||
| if (event.origin === 'http://localhost:8000') { |
There was a problem hiding this comment.
this callback should be wrapped in a runloop.
| libNames: Ember.A(), | ||
| name: null, | ||
| duration: 0, | ||
| sortedByHerz: function() { |
|
This is not a beta feature. We should stop sneaking everything into beta, this should really just enter on canary and stay for the appropriate cycles. |
|
@twokul can you rebase this and retag it as just |
|
This appears abandoned, closing. |
This PR introduces benchmarks for Ember.js. Originally, it came out of Composable CP PR.
Benchmarks are powered by ES6 modules, grunt and benchmark.js.
TODOs:
(right now benchmarks run against only two versions of Ember.js)
/cc @jdalton @stefanpenner @hjdivad @kselden