[FEATURE ember-eager-update-url] Eagerly update link-to urls #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the url in the address bar would only update at the very end up the transition. This change causes the url update to happen immediately unless the transition was aborted/redirected within the same run loop, which provides for a better UX 99% of the time.
stefanpenner
added a commit
that referenced
this pull request
Jan 11, 2014
[FEATURE ember-eager-update-url] Eagerly update link-to urls
|
Thanks dude! This has be irking me |
|
Yay!! ❤️ |
|
👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the url in the address bar would only update at the very end up
the transition. This change causes the url update to happen immediately unless
the transition was aborted/redirected within the same run loop, which provides
for a better UX 99% of the time.