Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Deprecate quoteless action names. #4276

Merged
merged 1 commit into from
Feb 2, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jan 31, 2014

This is preparation for enabling the ember-routing-bound-action-name feature.

As requested by @tomdale in #3936 (comment).

This should be pulled into the current 1.4.0 beta series, so that we can enable ember-routing-bound-action-name in the 1.5.0 beta series.

This is preparation for enabling the `ember-routing-bound-action-name`
feature.
@rwjblue
Copy link
Member Author

rwjblue commented Jan 31, 2014

My understanding is that we are going to pull this deprecation into beta (for 1.4.0), and then enable the feature for 1.5 (current canary).

@MajorBreakfast
Copy link
Contributor

Cool 👍 I'm looking forward to that.

stefanpenner added a commit that referenced this pull request Feb 2, 2014
[BUGFIX beta] Deprecate quoteless action names.
@stefanpenner stefanpenner merged commit d4a542f into emberjs:master Feb 2, 2014
rwjblue added a commit that referenced this pull request Feb 2, 2014
Using quoteless action names has been deprecated. In 1.5+ this will
result in bound property lookup (allowing dynamic action names).

Reference:

#4276
#3936
@rwjblue rwjblue deleted the deprecate-quoteless-actions branch February 2, 2014 15:19
@rwjblue
Copy link
Member Author

rwjblue commented Feb 2, 2014

Pulled into beta branch in 2ef00a2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants