[WIP] Add an assertion when watched props are are written to without Em.set. #9395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +81,10 @@ var get = function get(obj, keyName) { | |||
| if (Ember.FEATURES.isEnabled('mandatory-setter')) { | |||
| if (hasPropertyAccessors && meta && meta.watching[keyName] > 0) { | |||
| ret = meta.values[keyName]; | |||
|
|
|||
| if (ret === undefined && keyName in obj && !(keyName in meta.values)) { | |||
There was a problem hiding this comment.
this may be fine, but we should confirm no perf issue is caused by this in.
If there is we can always be clever and use one the sentinel UNDEFINED technique
There was a problem hiding this comment.
Agreed, I'll look into that.
Also, this whole section is completely removed from prod builds.
|
@krisselden - Would love your thoughts on both the issue and possibly how to make the failing test I referenced pass with this change... |
|
@krisselden ping |
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a property that is being watched (but was not available on the object at the time the watching was setup) is set directly (without
Ember.set), no assertion will be fired and anyEmber.get's on that property will returnundefined(see explanation). This PR adds an assertion to provide a path forward (basically useEmber.set).Closes #9387.
This is still a WIP, as it fails a single test that is actually relying on this behavior (setting a plain prop). Would love input on that test to see if it is possible to maintain its intent while refactoring to allow this PR/assertion.