Remove Handlebars packages from build pipeline. #9827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
remove-handlebars-packages
branch
from
d0457be to
0fd774a
Compare
Member
Author
Member
|
@rwjblue I can review this afternoon. |
Member
There was a problem hiding this comment.
Is this test run on CI with and without handlebars then?
Member
Author
There was a problem hiding this comment.
Not yet, but that is the goal. Haven't had a chance to make the conditional build with it just yet.
Member
There was a problem hiding this comment.
Seems like it would just never run in CI
Member
Author
There was a problem hiding this comment.
Correct, that is true today. After 1.10.0-beta.1 ships I plan to add another item to bin/run-tests.js that will add a query param (QUnit.urlconfig style) to do it.
mixonic
added a commit
that referenced
this pull request
Dec 9, 2014
Remove Handlebars packages from build pipeline.
Member
|
Bon. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handlebars packages are still in-repo, but now are not included in the build.