update release script and deployment README #45
Conversation
There was a problem hiding this comment.
Nice work here.
I have one concern here though. The updates here leave the person looking at this with the assumption that they can just run the script once and be finished. That’s an invalid assumption though. This script actually needs to be run twice: once, to build all the static files for the old version one last time (and update with all the changes made since the initial release of the old version) and then again for the new version.
That’s likely to be a moot point shortly, but if the difference here reflects a difference in how Ricardo and I do deploys, we may have accidentally thrown away all changes for some older versions of the guides as we transitioned between versions ...
| sed -Ei .bak "s/v[0-9]+[.][0-9]+[.][0-9]+/$VERSION/g" snapshots/_redirects |
There was a problem hiding this comment.
Are .bak files part of gitignore?
There was a problem hiding this comment.
I think we can remove .bak to avoid the temporary file.
|
@acorncom I thought Travis would commit here, but I guess it's deploying straight away. |
We automated more of the deployment and updated the README.
Blame @locks if it doesn't work