This repository has been archived by the owner on May 26, 2019. It is now read-only.
Update model-hook.md #2269
Merged
Update model-hook.md #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test fails if
assert.equal(this.element.querySelectorAll('.results .listing').length, 3, 'should display 3 listings');
because listings are not in an element with class "results"
jayjayjpg
approved these changes
Mar 12, 2018
|
according to the example set up in the super rentals repo listing is in results: |
|
|
|
yep you're right. good catch. |
This was referenced Mar 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fails if
assert.equal(this.element.querySelectorAll('.results .listing').length, 3, 'should display 3 listings');because listings are not in an element with class "results"