Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Remove references to sync queue #2295

Merged
merged 1 commit into from
Apr 15, 2018
Merged

Remove references to sync queue #2295

merged 1 commit into from
Apr 15, 2018

Conversation

jonnii
Copy link
Contributor

@jonnii jonnii commented Mar 17, 2018

The sync queue is deprecated in Ember 3.0.

The `sync` queue is deprecated in Ember 3.0.
@jonnii
Copy link
Contributor Author

jonnii commented Mar 18, 2018

@rwjblue there's an animation on that page too, I'm not sure where the code lives, I think it was written by machty a long time ago. Any ideas? I can update that too to remove sync from there if needed.

@acorncom
Copy link
Contributor

@jonnii It looks like it's an iframe that loads code up from here (https://s3.amazonaws.com/emberjs.com/run-loop-guide/index.html). Good catch there.

Looks like that's an Ember AppKit app that just does that one thing. If we change the referenced app though we'll change the app for all previous versions of the guides ...

We may want to temporarily copy that into the guides here and then revisit this after we've launched our new guides viewer ... /cc @mansona

@jonnii
Copy link
Contributor Author

jonnii commented Mar 22, 2018

@machty am I right in thinking that this is one of your creations?

@machty
Copy link

machty commented Mar 22, 2018

@jonnii yes, but it was forked and prettified; I believe this is the latest version https://github.com/olivia/ember-run-loop-visual/tree/ui-prettification (4-5 years ago!?!). Who's up for modifying and rebuilding an old ass ember app :)

@jonnii
Copy link
Contributor Author

jonnii commented Mar 22, 2018

@machty I'd be up for the challenge. let me take a look.

@jenweber jenweber merged commit 5bf2857 into emberjs:master Apr 15, 2018
@jenweber
Copy link
Contributor

Merged. Thanks @jonnii for reporting this and fixing it!

Deprecation is here emberjs/ember.js#16132

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants