Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

update models section to reflect renamed store methods #345

Merged
merged 1 commit into from
Jul 13, 2015

Conversation

csantero
Copy link
Contributor

@csantero csantero commented Jun 7, 2015

Based on the changes in emberjs/data#3235 and emberjs/data#3241

@HeroicEric
Copy link
Member

@csantero
Copy link
Contributor Author

csantero commented Jun 7, 2015

@HeroicEric Thanks, I've pushed a new diff with that change


The first argument to `store.find()` is always the record type. The optional second
argument determines if a request is made for all records, a single record, or a query.
argument determines if a request is made for all records or just a single record.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this behavior deprecated and people should use findAll? @bmac

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are being updated separately #346

@trek
Copy link
Member

trek commented Jun 12, 2015

cc @igorT

@michaelrkn
Copy link
Contributor

I think this should get merged in so that #346 can move forward with finishing the job (it already needs rebasing). @locks or @rwjblue can you do a final sanity check on this?

@locks
Copy link
Contributor

locks commented Jul 13, 2015

👍

mixonic added a commit that referenced this pull request Jul 13, 2015
update models section to reflect renamed store methods
@mixonic mixonic merged commit 066d322 into emberjs:master Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants