Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Jan Buschtöns <buschtoens@gmail.com>
  • Loading branch information
Chris Garrett and buschtoens authored Apr 17, 2020
1 parent cf3fed0 commit 1ef3267
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions text/0580-destroyables.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ class CustomSelect extends Component {
Returns the associated child for convenience.

- Attempting to associate a parent or child that has already been destroyed
should throw an error.
or is being destroyed should throw an error.

##### Multiple Inheritance

Expand Down Expand Up @@ -214,7 +214,7 @@ class Modal extends Component {
}
```

- Registering a destructor on a destroyed object should throw an error.
- Registering a destructor on a destroyed object or object that is being destroyed should throw an error.
- Attempting to register the same destructor multiple times should throw an
error.

Expand Down Expand Up @@ -287,10 +287,12 @@ destroying. Otherwise returns false.

```js
let obj = {};

isDestroying(obj); // false
destroy(obj);
isDestroying(obj); // true
// ...sometime later, after scheduled destruction
isDestroyed(obj); // true
isDestroying(obj); // true
```

#### `isDestroyed`
Expand Down

0 comments on commit 1ef3267

Please sign in to comment.