Skip to content

Commit

Permalink
Merge branch 'master' into advance-rfc-0821
Browse files Browse the repository at this point in the history
  • Loading branch information
wagenet authored Dec 13, 2022
2 parents c15b203 + dd3ea71 commit 912f95a
Show file tree
Hide file tree
Showing 5 changed files with 663 additions and 11 deletions.
16 changes: 8 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ Each Ember core team will be requested as a reviewer on the PR to move into this

- [ ] Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
- [ ] Any necessary learning materials have been updated
- [ ] The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature
- [ ] The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
- [ ] Criteria for moving to the Recommended Stage has been filled out
- [ ] This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP
- [ ] Each [team](https://github.com/emberjs/rfcs#relevant-teams) has been added as a reviewer to the PR at the start of the FCP
* [ ] Framework @emberjs/framework
* [ ] Data @emberjs/ember-data-core
* [ ] CLI @emberjs/cli
* [ ] Learning @emberjs/learning-core
* [ ] Typescript @emberjs/typescript-core
* [ ] Steering @emberjs/steering
- [ ] Each [team](https://github.com/emberjs/rfcs#relevant-teams) has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.
* Framework @emberjs/framework
* Data @emberjs/ember-data-core
* CLI @emberjs/cli
* Learning @emberjs/learning-core
* Typescript @emberjs/typescript-core
* Steering @emberjs/steering


## Criteria for moving to Recommended (required)
Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE/advance-to-released.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ An RFC is moved into "Released" when the above is verified by consensus of the r

## Checklist to move to Released

- [ ] The work is published in stable versions of the relevant package(s)
- [ ] The work is published in stable versions of the relevant package(s), with any feature flags toggled on.
- [ ] Deviations from the original RFC are noted in the RFC
- [ ] Release packages and dates are updated in the RFC frontmatter
2 changes: 1 addition & 1 deletion .github/actions/setup-rfcs-tooling/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:
with:
repository: emberjs/rfcs-tooling
path: rfcs-tooling
ref: 'v2.1.0'
ref: 'v2.1.1'

- uses: actions/setup-node@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion text/0226-named-blocks.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ them, and the mental/teaching model behind how it all works.
- Angle-bracket syntax does not support passing positional params

Implementation-wise, these varying semantics will be defined/implemented via
[Component Managers](https://github.com/emberjs/rfcs/blob/custom-components/text/0000-custom-components.md#componentmanager).
[Component Managers](https://github.com/emberjs/rfcs/blob/master/text/0213-custom-components.md#registering-component-managers).

## Multi-block Syntax

Expand Down
Loading

0 comments on commit 912f95a

Please sign in to comment.