Skip to content

Commit

Permalink
Remove unneeded comments, add a drawback I missed
Browse files Browse the repository at this point in the history
  • Loading branch information
chriskrycho committed Dec 3, 2021
1 parent 68a7c62 commit c599c05
Showing 1 changed file with 10 additions and 17 deletions.
27 changes: 10 additions & 17 deletions text/0779-first-class-component-templates.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,6 @@ Relevant Team(s): Ember.js, Learning, Ember CLI
RFC PR: https://github.com/emberjs/rfcs/pull/779
---

<!---
Directions for above:
Stage: Leave as is
Start Date: Fill in with today's date, YYYY-MM-DD
Release Date: Leave as is
Release Versions: Leave as is
Relevant Team(s): Fill this in with the [team(s)](README.md#relevant-teams) to which this RFC applies
RFC PR: Fill this in with the URL for the Proposal RFC PR
-->


# First Class Component Templates

Expand Down Expand Up @@ -941,15 +930,19 @@ A blog post can introduce the feature along these lines when the feature ships,
The analogy here would be if a JavaScript module could only have a single function or class in it, or a CSS file could only have a single declaration in it, regardless of what actually made sense for that particular module.
<!--
- The syntax offered here, `<template>`, overlaps with [a platform built-in][platform-template]. This may provoke some degree of confusion for users if they are familiar with it. However, there are several reasons to think this drawback is not significant:
- In practice `<template>` is very-little used, and only in the context of progressive enhancement with vanilla JS—not with frameworks.
- Although it looks a little odd, the platform-native `<template>` can still be nested *within* a `<template>` tag as defined here.
- Other frameworks (most notably Vue) have used `<template>` in much the same way we are here with no major confusion on the part of developers.
> Why should we *not* do this? Please consider the impact on teaching Ember,
on the integration of this feature with other existing and planned features,
on the impact of the API churn on existing apps, etc.
- Most importantly, there is no *actual* conflict with the platform built-in, since `<template>` is not *JavaScript* syntax, which is where we are using it.
> There are tradeoffs to choosing any path, please attempt to identify them here.
- As a bonus: in a certain sense, the use of `<template>` here “rhymes” with the version from the platform: it represents the dynamic HTML content associated with some JavaScript functionality.
-->
[platform-template]: http://developer.mozilla.org/en-US/docs/Web/HTML/Element/template
## Alternatives
Expand Down

0 comments on commit c599c05

Please sign in to comment.