Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the numbering in the md book output #524

Closed
chancancode opened this issue Aug 5, 2019 · 3 comments · Fixed by #526
Closed

Hide the numbering in the md book output #524

chancancode opened this issue Aug 5, 2019 · 3 comments · Fixed by #526

Comments

@chancancode
Copy link
Member

See https://emberjs.github.io/rfcs/

We want to change this:

  1. 0001-transform-attribute-meta-parameter
  2. 0003-block-params
  3. 0003-cli-ember-doctor
  4. 0010-engines
  5. 0011-improved-cp-syntax
  6. 0012-help-json-output
  7. 0015-the-road-to-ember-2-0
  8. 0020-sri-default
  9. ...

...into this...

0001-transform-attribute-meta-parameter
0003-block-params
0003-cli-ember-doctor
0010-engines
0011-improved-cp-syntax
0012-help-json-output
0015-the-road-to-ember-2-0
0020-sri-default
...

...or ideally, even this...

#1. Pass through attribute meta data to related Transform
#3 Block Params
#3 ember doctor
#10 Engines
...

We should be able to do the middle thing quickly with CSS, but maybe this is something we should PR to upstream (mdbook).

@makepanic
Copy link
Contributor

makepanic commented Aug 6, 2019

the second option already works when configuring mdbook with:

[output.html]
no-section-label = true

see https://rust-lang-nursery.github.io/mdBook/format/config.html#html-renderer-options

It seems like that option isn't supported in 0.0.26. I've installed the latest one and the output is as expected:

20190806-190813

I can open a PR which adds the config and bumps mdbook if you want

It seems like that option was supported for a very long time. Let me recheck if it works on .26 it was added in 0.1.0 but this repo still uses 0.0.26

@chancancode
Copy link
Member Author

@makepanic yes please 🙏

@makepanic
Copy link
Contributor

created #526 to fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants