-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Getter CP readOnly by default #12
Conversation
|
||
Overridable CP's are unexpected, hard to learn, and wanted in the minority of | ||
cases. When it happens unexpeditly it is nearly always unwanted and the resulting | ||
choas is hard to debug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/choas/chaos/
@tomdale r? |
# Motivation | ||
|
||
Overridable CP's are unexpected, hard to learn, and wanted in the minority of | ||
cases. When it happens unexpeditly it is nearly always unwanted and the resulting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/unexpeditly/unexpectedly/
What's the status here? Should we rebase and merge? |
pending @wycats pings |
Now that the new CP syntax is enabled in canary this should not take much time. I can take care of this since I already know that part of the codebase. |
@cibernox - I believe that there may be some open questions (just from reading the comments above), but it should be ready for initial implementation (and that could help answer some of those questions...). |
After discussing at the core team, we realized we get this for free when we migrate to the ES5 getter form. |
@tomdale I do have a local branch where I implemented this and IIRC it required very little changes. The concerns of the core team are related with this being deprecated with little notice? |
example of the future: export class extends Ember.Object {
@computed
otherName() {
}
@computed
get fullName() {
}
};
The benefit of this, is a totally clean upgrade process. A future RFC will explore and propose the formal adoption of decorators in ember. |
I see it and I like it. |
👍 |
@cibernox someone, (maybe you or me) should write up an RFC for the future integration of decorators. https://github.com/rwjblue/ember-computed-decorators is a fun example, but since babel fixed some things some serious issues (chaining is broken) now work. We should likely fix that soon, so we can continue to test in userland and the ES2016 spec matures. |
Add option for JSON output to help command
No description provided.