Code

Rethink Acceptance Testing#268

Code

Merged

rwjblue merged 27 commits intomasteremberjs/rfcs:masterfrom acceptance-testingemberjs/rfcs:acceptance-testingCopy head branch name to clipboardDec 1, 2017

+352

Commits

Commits on Nov 6, 2017

• Rethink Acceptance Testing

  rwjblue

  committed
  4ec916b

  Copy full SHA for 4ec916b

• Tweaks/corrections.

  rwjblue

  committed
  f779b71

  Copy full SHA for f779b71

• Tweak alternative.

  rwjblue

  committed
  3ee1064

  Copy full SHA for 3ee1064

• Fix typo in intro of detailed design.

  rwjblue

  committed
  cdbaecb

  Copy full SHA for cdbaecb

• Better document the DOM Helpers in the detailed design.

  rwjblue

  committed
  3c57791

  Copy full SHA for 3c57791

• Clarify that root element meant the applications root element.

  rwjblue

  committed
  5e6c1bd

  Copy full SHA for 5e6c1bd

• Remove this.$ helper.

  rwjblue

  committed
  12f4c7b

  Copy full SHA for 12f4c7b

• Clarify the reasoning for both helper types.

  rwjblue

  committed
  4bb6857

  Copy full SHA for 4bb6857

• Add alternative about leaving ember-native-dom-helpers.

  rwjblue

  committed
  a6950d9

  Copy full SHA for a6950d9

• Remove reference to this.set / this.setProperties / etc.

  rwjblue

  committed
  f7656ea

  Copy full SHA for f7656ea

• Remove public API suggestion for DOM interaction methods.

  Show description for 8975fb9
  rwjblue

  committed
  8975fb9

  Copy full SHA for 8975fb9

• Remove more this.foo references.

  rwjblue

  committed
  7ee7132

  Copy full SHA for 7ee7132

• Add blurb about removing implicit promise chaining.

  rwjblue

  committed
  1209ed3

  Copy full SHA for 1209ed3

Commits on Nov 8, 2017

• Tweak summary prose for clarity and purpose.

  rwjblue

  committed
  b05ed2c

  Copy full SHA for b05ed2c

• Migrate to use @ember/test-helpers.

  rwjblue

  committed
  ebfdbe1

  Copy full SHA for ebfdbe1

• Remove wrapping declare module statement.

  rwjblue

  committed
  39da814

  Copy full SHA for 39da814

Commits on Nov 9, 2017

• Add mention of removing default tests/helpers/*.js.

  rwjblue

  committed
  57792c2

  Copy full SHA for 57792c2

Commits on Nov 10, 2017

• Correct the options to waitFor and waitUntil.

  Show description for 1676701
  rwjblue

  committed
  1676701

  Copy full SHA for 1676701

• Add example of addon supporting both APIs.

  rwjblue

  committed
  ef325f4

  Copy full SHA for ef325f4

• Remove reference to find in example.

  rwjblue

  committed
  6e0975c

  Copy full SHA for 6e0975c

• Add example demonstrating factory overrides.

  rwjblue

  committed
  b487cb4

  Copy full SHA for b487cb4

• Add more details about waiting for the result of click et al

  rwjblue

  committed
  8858b09

  Copy full SHA for 8858b09

• Fix typos in test helper example.

  rwjblue

  committed
  0f55cd5

  Copy full SHA for 0f55cd5

• Remove extraneous option for test helpers.

  rwjblue

  committed
  8247efb

  Copy full SHA for 8247efb

Commits on Nov 11, 2017

• Update typings for waitFor and waitUntil.

  rwjblue

  committed
  cbe88eb

  Copy full SHA for cbe88eb

Commits on Nov 15, 2017

• Add type for code snippet.

  rwjblue

  committed
  6370fa8

  Copy full SHA for 6370fa8

• Rename import to setupApplicationTest.

  rwjblue

  committed
  f2b608b

  Copy full SHA for f2b608b