Make jQuery optional #294

simonihmig · 2018-01-12T21:14:35Z

rwjblue · 2018-01-12T21:28:40Z

Big 👍 here, thank you for taking the time to work on it!

Gaurav0 · 2018-01-13T00:06:11Z

text/0000-optional-jquery.md

+
+To not create any breaking changes, Ember CLI will have to check the app's dependencies for the presence of this addon. 
+If it is not present, it will continue importing jQuery *unless* the jQuery integration flag is disabled.
+In the other case, it will stop importing jQuery at all, and delegate this responsibility to the addon.


If it is present,

If it is present,

That's what I meant with In the other case, but I can rephrase this.

Gaurav0 · 2018-01-13T00:10:35Z

text/0000-optional-jquery.md

+
+To nudge users to install `@ember/jquery` when they need jQuery, some warning/deprecation messages should be issued when
+the addon is *not* installed and the integration flag is either not specified or is set to true. Only in the case the 
+app is actively opting out of jQuery integration the addon is not needed.


The @ember/jquery addon should be placed in the default blueprint for a period of time so as to ease migration.

Yep, absolutely agreed.

Gaurav0 · 2018-01-13T00:13:32Z

text/0000-optional-jquery.md

+  should throw an assertion stating that jQuery is not available.
+* `this.$()` in components
+  should throw an assertion stating that jQuery is not available and that `this.element` and native DOM APIs should be
+  used instead.


Should these throw deprecation warnings before jquery is removed?

No, I don't think so. Importantly, this RFC is not suggesting that usage of jQuery specific features are deprecated. It's providing for a way to opt-out of that feature set which is coherent.

There certainly may be an additional deprecation RFC down the road, but for now we are trying to ensure that either option (using jQuery integration features or not including jQuery) are viable coherent options for Ember apps...

Exactly. I had a second follow up RFC planned, that is more aggressive (and thus maybe controversial) about pushing away from jQuery, including deprecations as mentioned. But this would be complimentary to this one, so basically the second step (if adopted).

Gaurav0 · 2018-01-13T00:15:18Z

text/0000-optional-jquery.md

+### Guides
+
+The existing "Managing Dependencies" chapters in the Ember Guides as well as on ember-cli.com provide a good place to 
+explain users how to set the jQuery integration flag by means of the mentioned addon that handles this flag. 


Clarify this is not the @ember/jquery addon

Yes, great point. Currently we are thinking that it will be @ember/optional-features (WIP repo here)...

Gaurav0 · 2018-01-13T00:18:31Z

text/0000-optional-jquery.md

+
+For this reason this RFC encourages addon authors to not use jQuery anymore and to refactor existing usages whenever 
+possible! This certainly does not apply categorically to all addons, e.g. those that wrap jQuery plugins as 
+components and as such cannot drop this dependency.


Addons that require jquery should state that they do so.

At some point the end goal should be that such addons could simply include @ember/jquery in their dependencies and not have additional instructions.

Addons that require jquery should state that they do so.

Totally agreed! The current line of thinking is that addons that require jQuery (or any of the other optional features that we are adding opt-out capabilities for) can as @ember/optional-features if any given feature is enabled or disabled, this allows an addon that is (for example) wrapping a jQuery plugin ensure that jQuery integration is enabled (and @ember/jquery is present properly).

At some point the end goal should be that such addons could simply include @ember/jquery in their dependencies and not have additional instructions.

Possibly, but for now I think that we want to leave control of opting in or out of features in the hands of the application specifically.

Gaurav0 · 2018-01-13T00:23:14Z

text/0000-optional-jquery.md

+
+## Unresolved questions
+
+### jquery.Event vs. native events


In my opinion, this question needs to be somewhat resolved before this RFC can proceed, as it pretty much derails the whole show.

Yep, I agree that we need to reach a consensus on the best path forward here.

rwjblue · 2018-01-13T01:58:18Z

text/0000-optional-jquery.md

+accessed. However this can be misleading, as it may be required to use these jQuery specifics if a jQuery event is 
+passed, so there is technically no other way to prevent the deprecation warning to be triggered. 
+* is there a way to start passing *only* native events, which are augmented by jQuery specific properties like
+`originalEvent` (e.g. `event.originalEvenet = event`) to not break things, thus following SemVer while still 


typo: s/originalEvenet/originalEvent/

rwjblue · 2018-01-13T02:17:34Z

RE: The jQuery.Event vs native event situation, I think we have additional options that are not listed. The simplest solution that comes to my mind is:

Create a small addon that detects if jQuery integration is enabled or disabled (at build time), and provide a consistent interface to always convert to a native event. Something like:

// jQuery enabled version
export default function(jQueryEvent) {
  return jQueryEvent.originalEvent;
}

// jQuery disabled version
export default function(event) { 
  return event;
}

This utility function could be used where needed like:

import Component from '@ember/component';
import normalizeEvent from '@ember/some-awesome-name';

export default Component.extend({
  click(event) {
    let nativeEvent = normalizeEvent(event);
    // do stuff...
  }
})

I think there are a number of variations of this setup that would work nicely...

simonihmig · 2018-01-13T09:02:05Z

Create a small addon that detects if jQuery integration is enabled or disabled (at build time), and provide a consistent interface to always convert to a native event.

Love it!

I guess this would also allow to add some deprecation messages when accessing event.originalEvent directly, as mentioned in the chapter's 3rd bullet point. With some shenanigans we could make sure that this deprecation is not triggered when accessing this through the normalizeEvent function.

This would also allow the transition to pass native events only (would be a breaking change) be painless, as addons can be refactored immediately to only use native event semantics, even when jQuery events are still passed for now.

simonihmig · 2018-01-13T09:19:17Z

Just to give some more context, as this has been touched here: #294 (comment)...

This RFC is about providing an officially supported way to opt-out of jQuery. It is a non breaking change, and so far no deprecations are planned for this!

There will probably be a second follow up RFC, that is more aggressive (and thus maybe more controversial) about pushing away from jQuery, including deprecating jQuery coupled APIs like this.$(). Basically it would change the semantics from this one's "jQuery included by default, allow opt-out" to "removed by default, allow opt-in".

But that would be complimentary to this one and would obviously require the opt-out proposed here to be already possible, so it would basically be the second step (if adopted).

benkingcode · 2018-01-13T20:06:15Z

I'm not sure enabled by default is the best approach. Also, I'm a bit confused, does this mean there would be two addons - one called something like ember-disable-jquery and one for @ember/jquery? I think it'd be much more elegant if jQuery was disabled by default and users could simply install @ember/jquery, and tools like ember-cli-update could do that automatically.

simonihmig · 2018-01-13T22:32:08Z

does this mean there would be two addons - one called something like ember-disable-jquery

Managing the opt-out flag would be the responsibility of a dedicated addon, presumably ember-optional-features, which is not restricted to jQuery. See implementation outline

I think it'd be much more elegant if jQuery was disabled by default

I am also in favor of being more aggressive about moving away from jQuery at some point in time, but as I said that could be the subject of another follow up RFC. To really remove the existing jQuery support from ember-source (like this.$()) would be a breaking change, so can be done at Ember 4.0 at the earliest (with prior deprecation). Enabled by default is what we have today, and this RFC just opens the door to disable...

What we probably could do earlier is to opt-out by default in the default app blueprint, which would affect new apps, but would not break things for existing ones. But even that I think we should do carefully, when the most popular addons are known to work fine without jQuery, to not create a frustrating developer experience.

rwjblue · 2018-01-14T01:21:04Z

I think it'd be much more elegant if jQuery was disabled by default and users could simply install @ember/jquery, and tools like ember-cli-update could do that automatically.

I agree that is the longer term plan, but again this RFC is solely focused on allowing opting out to begin with. I believe as part of that plan, the default addon blueprint will begin testing without jQuery as well as with it and that will help make using Ember without jQuery easier and easier as addons update to absorb that change.

I absolutely agree with the goal of having ember new foo simply not use jQuery at all, we just need to move with care. 😸

benkingcode · 2018-01-14T01:24:46Z

By 'elegant' I meant it seems strange to me that a user would have to install something to remove something else. I agree that jQuery should be provided out of the box by default for now. But I think conceptually it doesn't make sense to have "lack of jQuery" being a new dependency.

rwjblue · 2018-01-14T01:41:15Z

By 'elegant' I meant it seems strange to me that a user would have to install something to remove something else.

Gotcha, sorry for misunderstanding!

But I think conceptually it doesn't make sense to have "lack of jQuery" being a new dependency.

Considering this RFC alone, I would completely agree with you. However, the actual intention here is to have a single @ember/optional-features addon that allows opting out of a number of currently defaulted features (application-template-wrapper and template-only-component-wrapper are the other two in addition to this one which would be jquery-integration). As features continue to be made optional (ultimately including being stripped from the build when not enabled) in Ember itself this list will grow even larger....

simonihmig · 2018-01-16T20:58:45Z

I just added a new section with a possible solution to the jQuery.Event vs. native issue, based on @rwjblue's suggestion here!

Please review! 🧐

Gaurav0 · 2018-01-17T17:20:55Z

text/0000-optional-jquery.md

+To solve this issue another addon `ember-jquery-legacy` will be introduced, which for now will only expose a single
+`normalizeEvent` function. This function will accept a native event as well as a jQuery event (possibly distinguishing
+between those two modes at build time, based on the jQuery integration flag), but will always return a native event 
+only. 


Will it be necessary for ember-jquery-legacy to be a dependency or can it be just a devdependency?

Will have to be a dependency (for an addon), as normalizeEvent needs to be imported in actual code, see the little code example! Only needed though if you currently require any jQuery specifics like originalEvent.

Gaurav0 · 2018-01-17T17:31:00Z

text/0000-optional-jquery.md

+To encourage addon authors to refactor their jQuery coupled event code, the use of `jQuery.Event` specific APIs used for
+jQuery events passed to component event handlers should be deprecated and a deprecation message be shown when accessing 
+them (e.g. `event.originalEvent`). Care must be taken though that this warning will not be issued when `normalizeEvent` 
+has to access `originalEvent`. 


This may require passing something that extends jquery.Event.

Gaurav0 · 2018-01-17T17:35:03Z

text/0000-optional-jquery.md

+possible, like enabling tree shaking with the new [Module API](https://github.com/emberjs/rfcs/blob/master/text/0176-javascript-module-api.md),
+moving code from core to addons (e.g. the [`Ember.String` deprecation](https://github.com/emberjs/rfcs/blob/master/text/0236-deprecation-ember-string.md))
+or the ["Explode RFC"](https://github.com/emberjs/rfcs/blob/explode/text/0000-explode.md). In that regard removing the 
+dependency on jQuery is a rather low hanging fruit with an high impact.


Considering the implementation complexity, describing this as "low hanging fruit" seems ridiculous.

Which implementation complexity are you referring to? For Ember itself, most of the hard work has already been done, what is proposed here should not be too hard to implement.

If you refer to user's apps, sure that might involve a lot of work to get rid of jQuery depending on the amount of jQuery code (so "your milage may vary"). However nobody forces you to do so, and for apps with less of an jQuery legacy, removing it could be a big and rather easy win!

rwjblue · 2018-01-22T15:31:12Z

We discussed this at the core team meeting on 2018-01-19, and believe it is ready for final comment period.

Making it so...

rwjblue · 2018-02-04T21:19:37Z

Thanks to all those that helped push this forward! There have been no new concerns brought up while this has been in the final comment period, and the core team is still very excited to move forward with it.

✂️

Optional jQuery RFC

92ba061

Gaurav0 reviewed Jan 13, 2018

View reviewed changes

rwjblue reviewed Jan 13, 2018

View reviewed changes

Tweaks and fixes

1c71062

Added possible solution for jQuery.Event migration

4a98c4e

buschtoens mentioned this pull request Jan 17, 2018

feat(wait-for/event): support native DOM EventTargets machty/ember-concurrency#187

Merged

Gaurav0 reviewed Jan 17, 2018

View reviewed changes

rwjblue added the Final Comment Period label Jan 22, 2018

willviles mentioned this pull request Jan 25, 2018

Autofocus on didRender adfinis/ember-validated-form#84

Closed

simonihmig mentioned this pull request Jan 27, 2018

[WIP] Remove jQuery guide emberjs/guides#2191

Closed

add RFC PR

7523af7

locks assigned wycats and rwjblue Feb 4, 2018

locks added the T-framework RFCs that impact the ember.js library label Feb 4, 2018

rwjblue merged commit 5b5d1d0 into emberjs:master Feb 4, 2018

josemarluedke mentioned this pull request Feb 13, 2018

Remove usage of jQuery adopted-ember-addons/ember-burger-menu#105

Closed

3 tasks

simonihmig mentioned this pull request May 28, 2018

Add "Remove jQuery" guide ember-learn/guides-source#64

Merged

rwjblue mentioned this pull request Jun 1, 2018

Ember 3.2 Release Blog Post emberjs/website#3350

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make jQuery optional #294

Make jQuery optional #294

simonihmig commented Jan 12, 2018

rwjblue commented Jan 12, 2018

Gaurav0 Jan 13, 2018

simonihmig Jan 13, 2018

Gaurav0 Jan 13, 2018

rwjblue Jan 13, 2018

Gaurav0 Jan 13, 2018

rwjblue Jan 13, 2018

simonihmig Jan 13, 2018

Gaurav0 Jan 13, 2018

rwjblue Jan 13, 2018

Gaurav0 Jan 13, 2018

rwjblue Jan 13, 2018

Gaurav0 Jan 13, 2018

rwjblue Jan 13, 2018

rwjblue Jan 13, 2018

rwjblue commented Jan 13, 2018

simonihmig commented Jan 13, 2018 •

edited

Loading

simonihmig commented Jan 13, 2018

benkingcode commented Jan 13, 2018 •

edited

Loading

simonihmig commented Jan 13, 2018

rwjblue commented Jan 14, 2018

benkingcode commented Jan 14, 2018

rwjblue commented Jan 14, 2018

simonihmig commented Jan 16, 2018

Gaurav0 Jan 17, 2018

simonihmig Jan 17, 2018

Gaurav0 Jan 17, 2018

Gaurav0 Jan 17, 2018

simonihmig Jan 17, 2018

rwjblue commented Jan 22, 2018

rwjblue commented Feb 4, 2018

Make jQuery optional #294

Make jQuery optional #294

Conversation

simonihmig commented Jan 12, 2018

rwjblue commented Jan 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwjblue commented Jan 13, 2018

simonihmig commented Jan 13, 2018 • edited Loading

simonihmig commented Jan 13, 2018

benkingcode commented Jan 13, 2018 • edited Loading

simonihmig commented Jan 13, 2018

rwjblue commented Jan 14, 2018

benkingcode commented Jan 14, 2018

rwjblue commented Jan 14, 2018

simonihmig commented Jan 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwjblue commented Jan 22, 2018

rwjblue commented Feb 4, 2018

simonihmig commented Jan 13, 2018 •

edited

Loading

benkingcode commented Jan 13, 2018 •

edited

Loading