Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author Built-In Blueprints in TypeScript #776

Merged
merged 10 commits into from
Jan 5, 2022

Conversation

cafreeman
Copy link
Contributor

@cafreeman cafreeman commented Nov 16, 2021

In order to support both TypeScript and JavaScript as official languages in Ember, we should enable blueprints to be written in TypeScript and (optionally) transformed to JavaScript. We should also convert all of the existing built-in blueprints to TypeScript to take advantage of this new functionality and lay the groundwork for future TypeScript inclusion efforts.

rendered

@rwjblue rwjblue added the T-ember-cli RFCs that impact the ember-cli library label Nov 16, 2021
@rwjblue
Copy link
Member

rwjblue commented Nov 16, 2021

Thanks for working on this @cafreeman!

@wagenet
Copy link
Member

wagenet commented Nov 17, 2021

This seems like a great idea! I look forward to reviewing it in detail.

Copy link
Member

@wagenet wagenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% on board with this and, at this point, don't have any concerns or further suggestions!

@kategengler
Copy link
Member

kategengler commented Dec 1, 2021

"How we teach this" should probably cover authoring blueprints, in as much as they are covered on the cli guides.

See https://cli.emberjs.com/release/advanced-use/blueprints/

@rwjblue
Copy link
Member

rwjblue commented Dec 1, 2021

We discussed this in today's ember-cli team meeting, and are generally in favor of moving forward. There were a few things called out during that discussion that we think needs to be updated:

  • "How we teach this" should include information about updating the blueprint authoring guides (see Author Built-In Blueprints in TypeScript #776 (comment))
  • We should explicitly add the --typescript flag (supporting blueprint generation with typescript if the underlying blueprint was actually authored in typescript). We can also call out that adding "typescript": true to .ember-cli is a convenient way to ensure that users in a project get typescript blueprints whenever possible (it could even suggest that the ember-cli-typescript blueprint be updated to add that for folks automatically).

@cafreeman - Once those tweaks are made, I think this will be ready for another look.

@cafreeman
Copy link
Contributor Author

Thanks for the feedback @kategengler and @rwjblue! I've just pushed an update that should address both issues that were brought up. Let me know if you've got any other comments!

@rwjblue
Copy link
Member

rwjblue commented Dec 17, 2021

Thanks for the updates @cafreeman!! We discussed this at the last ember-cli team meeting, and are moving this into final comment period.

@rwjblue rwjblue merged commit c174f2f into emberjs:master Jan 5, 2022
wagenet added a commit that referenced this pull request Mar 13, 2023
Advance RFC #776 "Author built-in blueprints in Typescript" to Stage Ready for Release
wagenet added a commit that referenced this pull request Mar 13, 2023
Advance RFC #776 `"Author Built-In Blueprints in TypeScript"` to Stage Released
ef4 added a commit that referenced this pull request Dec 15, 2023
Advance RFC #776 `"Author Built-In Blueprints in TypeScript"` to Stage Recommended
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period T-ember-cli RFCs that impact the ember-cli library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants