Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation using Debug-Render-Tree #778

Closed
wants to merge 20 commits into from

Conversation

michaelbdai
Copy link

@michaelbdai michaelbdai commented Dec 3, 2021

@michaelbdai michaelbdai changed the title v0, initial draft. Instrumentation using Debug-Render-Tree Dec 3, 2021
@MelSumner
Copy link
Contributor

MelSumner commented Dec 7, 2021

@michaelbdai Thank you for submitting this RFC. There are quote indicators throughout the RFC- I've marked a few of them for how to fix as an example. Can you remove the rest of them? thank you so much!

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading through the RFC, it is not clear what problem you are trying to solve. Can you describe (and update the Summary / Motivation) what the gaps with the current debug render tree information are?

@michaelbdai
Copy link
Author

michaelbdai commented Dec 10, 2021

Hi @rwjblue,
Thanks for the feedback. I update the Motivation section.
The gap is not with debug render tree. It is instrumentation needed to be improved. I basically proposing integration instrumentation with enhanced debug render tree.

@wagenet
Copy link
Member

wagenet commented Jul 23, 2022

@michaelbdai are you still wanting to move this forward? If so, I'll work to get it moving again.

@michaelbdai
Copy link
Author

@wagenet Sorry for the late reply.
yes, I'd like to get it moving.
Just want to clarify. Would you like to be the champion?
Or you plan to go ahead implement it?

@wagenet
Copy link
Member

wagenet commented Aug 23, 2022

@michaelbdai neither :) But I'm working to help get RFCs unblocked in general.

@michaelbdai
Copy link
Author

@wagenet I left LinkedIn in May and no longer working on Ember App. It would be pretty difficult for me to pick it up. I checked with my previous coworker at LinkedIn today. They are not interested.
I will go ahead close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants