Advance RFC #0236 to Stage Ready for Release

[emberjs-rfcs-bot]

Advance #236 to the Ready For Release Stage

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

• PR to Accepted Stage: Ember.String deprecation RFC #236

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

• Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
• Any necessary learning materials have been updated
• The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
• Criteria for moving to the Recommended Stage has been filled out
• This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
• Each team has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.
  • Framework @emberjs/framework
  • Data @emberjs/ember-data-core
  • CLI @emberjs/cli
  • Learning @emberjs/learning-core
  • Typescript @emberjs/typescript-core
  • Steering @emberjs/steering

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

1. The deprecated code has been removed in 5.0
2. Ensure guides and documentation have been updated to show @ember/string as an external package

Track Implementation

<-- Use this section to track implementation of the RFC -->

• Move htmlSafe and isHTMLSafe to @ember/template completed in ember-source 3.8 and in docs
• Create an @ember/string package with the remaining public API the published version is 3.0.1, around a long time
• Make ember-cli-babel aware of the @ember/string package completed long ago
• Deprecate loc in @ember/string deprecated in 3.24 and removed in 4.0
• Deprecate String prototype extensions done in 3.x and removed in 4.0
• Update usages in Ember and Ember Data codebases so that the projects do not trigger deprecations ember-data depends on the @ember/string package Move @ember/string to peerDep? data#8393
• Deprecate Ember.String Deprecate @ember/string when used from ember-source; point users to add the @ember/string addon ember.js#20344
  • write deprecation guide Add a deprecation guide for the move of @ember/string to an external package ember-learn/deprecation-app#1257
• Check new app and tutorial do not cause deprecations
  • ember-resolver uses @ember/string, add it as a peer dependency Add @ember/string as a peerDep ember-cli/ember-resolver#862
  • Add @ember/string to the app blueprint [ENHANCEMENT] Add @ember/string as a dependency in app blueprint ember-cli/ember-cli#10125