Missing Deprecations in Deprecations Guide

[Gaurav0]

Please add to the deprecations guide here: http://emberjs.com/deprecations/v1.x/.

These are all of the deprecations in 1.13.x that need to be covered:

• http://emberjs.com/blog/2015/06/12/ember-1-13-0-released.html
  • Ember.CoreView (63deb39)
  • Ember.View (Deprecation Guide for Ember.View #2195)
  • Ember.CollectionView (Add deprecation guide for ContainerView and CollectionView #2265)
  • Ember.ContainerView (Add deprecation guide for ContainerView and CollectionView #2265)
  • {{view 'some-helper'}} (Deprecation Guide for Ember.View #2195)
  • The {{view}} keyword for accessing properties on a view (Deprecated keywords #2198)
  • The {{controller}} keyword for accessing properties on a controller (Deprecated keywords #2198)
  • Options to the {{#each helper that trigger a legacy and poorly performing legacy layer. These options are: itemView, itemViewClass, tagName, emptyView and emptyViewClass (Add deprecation guide for all the each helper options #2328)
  • The itemController argument for {{#each. (Add deprecation guide for all the each helper options #2328)
  • bind-attr (bind-attr deprecation #2305)
  • Reading this.get('template') to check for a yielded block on components. (document remaining deprecations for 1.13.0 and 1.13.1 #2433)
  • Non-block param {{with (e6cd07b)
  • The view and viewClass params for {{outlet}} (document remaining deprecations for 1.13.0 and 1.13.1 #2433)
  • {{#each foo in bar}}{{/each}} (e6cd07b)
  • Ember.EnumerableUtils (document remaining deprecations for 1.13.0 and 1.13.1 #2433)
  • Allow deprecated access to template in component to determine if a block was provided. (document remaining deprecations for 1.13.0 and 1.13.1 #2433)
  • Ember.LinkView (Add entry for Ember.LinkView deprecation  #2197)
  • Ember.computed.any (Added deprecation guide about Ember.computed.any #2313)
  • Ember.Select (Adds a deprecation guide section about Ember.Select #2201)
  • Ember.arrayComputed (Note on array/reduce computed being deprecated #2203)
  • Ember.ReduceComputedProperty (document remaining deprecations for 1.13.0 and 1.13.1 #2433)
  • Ember.ArrayComputedProperty (document remaining deprecations for 1.13.0 and 1.13.1 #2433)
  • Ember.reduceComputed (Note on array/reduce computed being deprecated #2203)
  • beforeOberver (Move beforeObserver deprecation entry from 1.10 to 1.13 #2246)
  • Modifying a property inside of didInsertElement (Reported in Add deprecation about modifying properties inside the didInsertElement hook to the deprecations guide ember.js#12290) (document remaining deprecations for 1.13.0 and 1.13.1 #2433)
• https://github.com/emberjs/ember.js/blob/v1.13.1/CHANGELOG.md#1131-june-16-2015
  • Ember.immediateObserver
  • Ember.ArrayController (Add ArrayController to 1.13 deprecations #2258)
  • Ember.RenderBuffer (document remaining deprecations for 1.13.0 and 1.13.1 #2433)
• https://github.com/emberjs/ember.js/blob/v1.13.2/CHANGELOG.md#1132-june-16-2015
  • @guid
  • @item
• https://github.com/emberjs/ember.js/blob/v1.13.3/CHANGELOG.md#1133-july-5-2015
  • Ember.Object.createWithMixins (createWithMixins deprecation doc #2295)
  • Ember.oneWay (Deprecation guide for Ember.oneWay. #2302)
  • Ember.keys (Deprecation guide for Ember.create and Ember.keys #2296)
  • Ember.create (Deprecation guide for Ember.create and Ember.keys #2296)
• https://github.com/emberjs/ember.js/blob/v1.13.5/CHANGELOG.md
  • Controller#needs (Add deprecation guide for Controller#needs #2266)
  • Ember.Freezable (Ember Freezeable deprecation #2293)
  • frozenCopy (Document Remaining Deprecations for 1.13.5 #2428)
  • Ember.oneWay (Deprecation guide for Ember.oneWay. #2302)
  • Deprecate reverse argument ordering in Ember.observer. (Add deprecation for reversed observer arguments #2298)
  • Deprecate slash for a namespace in the {{render}} helper. (Document Remaining Deprecations for 1.13.5 #2428)
  • Function#observesBefore (Document Remaining Deprecations for 1.13.5 #2428)
  • Add deprecation messages when using Ember.get / Ember.set in a certain ways. (Document Remaining Deprecations for 1.13.5 #2428)
• https://github.com/emberjs/ember.js/blob/v1.13.6/CHANGELOG.md
  • Ember.Handlebars.makeViewHelper (Add guide for helper methods deprecations #2330)
  • Ember.HTMLBars.makeViewHelper (Add guide for helper methods deprecations #2330)
  • Ember.HTMLBars._registerHelper (Add guide for helper methods deprecations #2330)
  • Ember.HTMLBars.makeBoundHelper (Add guide for helper methods deprecations #2330)
  • Ember.Handlebars.makeBoundHelper (Add guide for helper methods deprecations #2330)
  • Ember.Handlebars.registerBoundHelper (Add guide for helper methods deprecations #2330)
  • Ember.Handlebars.helper (Add guide for helper methods deprecations #2330)
  • Ember.Handlebars.registerHelper (Add guide for helper methods deprecations #2330)
  • Ember.ContainerView (Add deprecation guide for ContainerView and CollectionView #2265)
  • Ember.CollectionView (Add deprecation guide for ContainerView and CollectionView #2265)
  • Deprecate specifying positionalParams at extend time in favor of using static factory properties.
• https://github.com/emberjs/ember.js/blob/v1.13.7/CHANGELOG.md
  • Deprecate using controller for {{with}} (72ab4e6)
  • {{#unbound}}{{/unbound}} (Add deprecation docs for unbound #2289)
  • {{unbound}} with multiple params (Add deprecation docs for unbound #2289)
  • Deprecate specifying render function to Ember.View or Ember.Component at extend time. (72ab4e6)
  • Ember.TrackedArray (72ab4e6)
  • Ember.SubArray (72ab4e6)
  • Deprecate using @each as a leaf node in a dependent key. (72ab4e6)

Thank you!

[wifelette]

I just went through all the minutes on the list here, added the weeks that were missing (as in, happened after this initial issue was filed) and pulled in all the specific details of the deprecations in each, as sublists. People have been fixing them piecemeal, so I wanted to be able to track exactly what was and wasn't done. I also checked off all the ones that had been done, and added links to their respective PRs.

Also, breaking it down like this hopefully makes these smaller tasks, so more people can jump in and help with little parts.

[trek]

I think @dstaley is working on a much larger version of this: dstaley/ember.js#1

Although I don't understand why he's tracking the issue on his branch vs mainline

[trek]

Could the two of you work together to flesh out the full list please? Thanks.

[wifelette]

I commented there. Hopefully he'll jump in here and help :)

[dstaley]

@wifelette Definitely up for helping out! Just let me know what makes the most sense as far as where to put tracking issues, where to send PRs, etc. My original idea was to track the issues on my branches as PRs are sent to the branch, and then send on one big PR to mainline when it was done. If it makes more sense to track here and send PRs to a branch or something else just let me know.

[wifelette]

Howdy @dstaley! I think my thought was mostly the usual—PRs submitted to the website repo, added as a reference here, checked off when merged :)

I can't help write much of this content, but I can keep on top of it and get the PRs merged as quickly as possible, which has been part of the issue in the past. As in, sometimes people try helping with this, but then the PRs just sit around and waste away. Innocently of course, it's just that there's SO much else happening. So if I'm aggressively getting things merged, and we can get a couple people to help, this should hopefully be a much quicker task than it previously was.

Having the main bit of work living here means it's more discoverable, so I'm hoping more people notice it, and I'll be able to draw more specific attention to it. (Also I hadn't noticed your thing when I spent the couple hours sifting through everything last night, or the job might've been a lot easier 😜 Sounds like my life 😄 )

It's probably helpful to comment here when self-assigning an item, or add a username after the list item, a.k.a. "I'm tackling X", so other folks choose different things to tackle.

[wifelette]

Update: a bunch of helpful folk are hanging in the #documentation channel on the Ember Community Slack, interested in this very topic :)

[wifelette]

Thanks @martndemus, updated and linked to commit :)

[workmanw]

Ember.SortableMixin seems to be gone in 2.0. I briefly looked around, but found no mention of its deprecation or disappearance.

[ultimatemonty]

Request to add emberjs/ember.js#11493 to the deprecations guide along with the reasoning behind it and acceptable alternatives. There are only 2 events that run only on component first run (didInitAttrs and didInsertElement) and the only place to init something like a jquery plugin wrapper is didInsertElement.

Thanks for all you folks do!

[wifelette]

@ultimatemonty Added to the list, thanks!

[wifelette]

@workmanw SortableMixin was part of the controller feature in 1.13, and it was removed (along with many other controller deprecations). However, it's still available in the Legacy Controller Addon (at https://github.com/emberjs/ember-legacy-controllers/blob/master/addon/utils/sortable-mixin.js), and it would great to get a PR pointing people to the Mixin for that feature :)

[workmanw]

@wifelette et al -- I'd be happy to submit a pull for SortableMixin ... but it wasn't actually deprecated in a literal sense, it was just kind of removed without warning. So it doesn't fit within the literal sense of "DEPRECATIONS ADDED IN 1.13". But if that seems okay, I'll open a PR.

[workmanw]

@wifelette Now that Ember.SortableMixin has been deprecated in Ember 1.x. I've added #2405.

[toddjordan]

I can start gradually working through the some of the rest of these. I'll start at the batch from 1.13.7 and start working my way back. Starting with TrackedArray and SubArray...

[toddjordan]

ok, this week I'll move on to the @guid and @item deprecations from 1.13.2

[toddjordan]

Moving on to the remaining 1.13.5 deprecations

[acorncom]

@wifelette @toddjordan #2428 was just merged. I just updated the checkboxes above to reflect that, which means at this point, I believe all deprecations are documented. Is that true?

@wifelette I'll leave the pleasure of closing this issue to you :-)

[wifelette]

Hah! I'm out this week and was legit sad that someone else would get to close it ;) Thanks everyone for helping make this happen!

[Gaurav0]

Thank you all for your hard work on this.