Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Add note with the only breaking change in Ember 2.0: Ember.set #2315

Closed

Conversation

cibernox
Copy link
Contributor

No description provided.

@cibernox
Copy link
Contributor Author

@mixonic @stefanpenner Brought by emberjs/ember.js#12095

@stefanpenner
Copy link
Member

Can you include the rationale. Proper es semantics and sanity with super in cp

@cibernox
Copy link
Contributor Author

@stefanpenner can you remind me the problem with super?

@stefanpenner
Copy link
Member

I cant really recall, but i think it was something like:

computed('other', {
  get() { return this.get('other'); },
  set(_, v) { 
    // some code that is a setter
    return this.set('other', v); // returns the wrong thing
    // vs 
    return this._super(); // returns the right thing
   }
})

@cibernox cibernox force-pushed the mention_ember_set_breaking_change branch from 1b6bd4f to eb4ed1c Compare August 14, 2015 21:40
@rwjblue
Copy link
Member

rwjblue commented Nov 6, 2015

seems like this needs a rebase

@rwjblue rwjblue closed this Mar 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants