This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
[On Hold] Removed Ember.merge from the list of 2.x deprecations.
#2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ember.js#13344 it is being undeprecated.
|
I looked at both blog posts, "EMBER.JS 2.4 AND 2.5 BETA RELEASED" and "EMBER.JS 2.4-LTS, 2.5, AND 2.6 BETA RELEASED", both introduce |
|
@workmanw - Since this URL is included in 2.5.0, I think we should wait at least until 2.5.1 is released. I'd hate to have a URL listed in a deprecation that doesn't work. |
|
@rwjblue Ah yes, that's an excellent point. I'll update the subject line to have |
workmanw
changed the title
Ember.merge from the list of 2.x deprecations. Ember.merge from the list of 2.x deprecations.
|
No, no. I'm just saying we can't merge until 2.5.1 is released, which should be Monday/Tuesday of this week. |
|
2.5.1 has been released. |
|
Thanks @Gaurav0 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per emberjs/ember.js#13344 it is being undeprecated.
EDIT: Do not merge just yet. We should wait at least until Ember 2.5.1 has shipped with the deprecation removed.