Add CMake Integration #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added support for installation which will be important to add a Conan package for ECOS. |
Correct version number
smerkli
reviewed
Sep 10, 2020
smerkli
reviewed
Sep 10, 2020
There was a problem hiding this comment.
Thank you for this, CMake integration is always nice!
I have tried this out and it worked fine on macOS (Catalina) and Linux (Debian unstable). I've added comments for the things that'd need to change for Windows support. If you like, you can fix that, otherwise please add a comment at the top of the file saying this currently does not support builds on Windows. We could make a followup issue to add support in that case.
|
Thanks for checking it on Windows as well, I completely forgot to consider the differences. I made the changes you suggested and it should work now. |
smerkli
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to use ECOS in CMake projects e.g. in the Epigraph library. The current process is not very elegant and difficult to use cross-platform.
This change is