Misc clean up

embrace-io · Oct 23, 2023 · 6e930cb · 6e930cb
1 parent e1a7278
commit 6e930cb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/EmbraceImpl.java b/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/EmbraceImpl.java
@@ -1572,7 +1572,7 @@ EmbraceInternalInterface getEmbraceInternalInterface() {
         if (isStarted() && embraceInternalInterface != null) {
             return embraceInternalInterface;
         } else {
-            return EmbraceInternalInterfaceKt.getDefault();
+            return EmbraceInternalInterfaceKt.getDefaultImpl();
         }
 
     }

diff --git a/...e-android-sdk/src/main/java/io/embrace/android/embracesdk/EmbraceInternalInterfaceImpl.kt b/...e-android-sdk/src/main/java/io/embrace/android/embracesdk/EmbraceInternalInterfaceImpl.kt
@@ -164,13 +164,6 @@ internal class EmbraceInternalInterfaceImpl(
         embraceImpl.recordAndDeduplicateNetworkRequest(callId, embraceNetworkRequest)
     }
 
-    /**
-     * Determine if a network call should be captured based on the network capture rules
-     *
-     * @param url    the url of the network call
-     * @param method the method of the network call
-     * @return the network capture rule to apply or null
-     */
     override fun shouldCaptureNetworkBody(url: String, method: String): Boolean = embraceImpl.shouldCaptureNetworkCall(url, method)
 
     override fun setProcessStartedByNotification() {

diff --git a/...roid-sdk/src/main/java/io/embrace/android/embracesdk/internal/EmbraceInternalInterface.kt b/...roid-sdk/src/main/java/io/embrace/android/embracesdk/internal/EmbraceInternalInterface.kt
@@ -1,6 +1,7 @@
 package io.embrace.android.embracesdk.internal
 
 import android.util.Pair
+import io.embrace.android.embracesdk.Embrace
 import io.embrace.android.embracesdk.InternalApi
 import io.embrace.android.embracesdk.LogType
 import io.embrace.android.embracesdk.network.EmbraceNetworkRequest
@@ -13,15 +14,15 @@ import io.embrace.android.embracesdk.network.http.NetworkCaptureData
 @InternalApi
 public interface EmbraceInternalInterface {
     /**
-     * {@see Embrace#logInfo}
+     * See [Embrace.logInfo]
      */
     public fun logInfo(
         message: String,
         properties: Map<String, Any>?
     )
 
     /**
-     * {@see Embrace#logWarning}
+     * See [Embrace.logWarning]
      */
     public fun logWarning(
         message: String,
@@ -30,7 +31,7 @@ public interface EmbraceInternalInterface {
     )
 
     /**
-     * {@see Embrace#logError}
+     * See [Embrace.logError]
      */
     public fun logError(
         message: String,
@@ -40,7 +41,7 @@ public interface EmbraceInternalInterface {
     )
 
     /**
-     * {@see Embrace#logHandledException}
+     * Backwards compatible way for hosted SDKs to log a handled exception with different log levels
      */
     public fun logHandledException(
         throwable: Throwable,
@@ -95,7 +96,7 @@ public interface EmbraceInternalInterface {
      * Record a network request and overwrite any previously recorded request with the same callId
      *
      * @param callId                the ID with which the request will be identified internally. The session will only contain one recorded
-     * request with a given ID - last writer wins.
+     *                              request with a given ID - last writer wins.
      * @param embraceNetworkRequest the request to be recorded
      */
     public fun recordAndDeduplicateNetworkRequest(
@@ -127,7 +128,7 @@ public interface EmbraceInternalInterface {
     public fun isNetworkSpanForwardingEnabled(): Boolean
 }
 
-internal val default = object : EmbraceInternalInterface {
+internal val defaultImpl = object : EmbraceInternalInterface {
 
     override fun logInfo(message: String, properties: Map<String, Any>?) { }