Skip to content

Commit

Permalink
Merge pull request #70 from embrace-io/crash-sending-docs
Browse files Browse the repository at this point in the history
Document crash sending strategy
  • Loading branch information
fractalwrench authored Nov 15, 2023
2 parents eb47bec + 68d3b49 commit e94b282
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,13 @@ internal class EmbraceCrashService(
// End, cache and send the session
sessionService.handleCrash(crash.crashId)
backgroundActivityService?.handleCrash(crash.crashId)
// Send the crash

// Send the crash. This is not guaranteed to succeed since the process is terminating
// and the request is made on a background executor, but data analysis shows that
// a surprising % of crashes make it through based on the receive time. Therefore we
// attempt to send the crash and if it fails, we will send it again on the next launch.
deliveryService.sendCrash(crashEvent)

// Indicate that a crash happened so we can know that in the next launch
crashMarker.mark()
}
Expand Down

0 comments on commit e94b282

Please sign in to comment.