Use in-memory key for signing (#1046) (#1047)

## Goal Cherrypick of #1046 into 6.9 release branch
embrace-io · Jul 4, 2024 · fd143e7 · fd143e7
1 parent 6476bea
commit fd143e7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -42,10 +42,6 @@ nexusPublishing {
 }
 
 allprojects {
-    ext.properties["signing.keyId"] = System.getenv("mavenSigningKeyId") ?: localProperties.getProperty("signing.keyId")
-    ext.properties["signing.secretKeyRingFile"] = System.getenv("mavenSigningKeyRingFile") ?: localProperties.getProperty("signing.secretKeyRingFile")
-    ext.properties["signing.password"] = System.getenv("mavenSigningKeyPassword") ?: localProperties.getProperty("signing.password")
-
     repositories {
         google()
         maven(url = "https://plugins.gradle.org/m2/")

diff --git a/buildSrc/src/main/kotlin/embrace-defaults.gradle.kts b/buildSrc/src/main/kotlin/embrace-defaults.gradle.kts
@@ -57,11 +57,13 @@ android {
             }
         }
     }
+
     buildTypes {
         named("release") {
             isMinifyEnabled = false
         }
     }
+
     publishing {
 
         // create component with single publication variant
@@ -197,6 +199,10 @@ publishing {
 }
 
 signing {
+    val keyId = System.getenv("mavenSigningKeyId")
+    val key = System.getenv("mavenSigningKeyRingFileEncoded")
+    val password = System.getenv("mavenSigningKeyPassword")
+    useInMemoryPgpKeys(keyId, key, password)
     sign(publishing.publications.getByName("release"))
 }