Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename function on data source #1026

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Rename function on data source #1026

merged 1 commit into from
Jul 3, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Renames alterSessionSpan to captureData as IMO this better reflects what the function is doing.

@fractalwrench fractalwrench requested a review from a team as a code owner July 3, 2024 10:13
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (b5237d1) to head (f96cd0e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   79.73%   79.76%   +0.03%     
==========================================
  Files         416      416              
  Lines       10775    10775              
  Branches     1763     1763              
==========================================
+ Hits         8591     8595       +4     
+ Misses       1402     1398       -4     
  Partials      782      782              
Files Coverage Δ
...ndroid/embracesdk/anr/sigquit/SigquitDataSource.kt 33.33% <100.00%> (ø)
...droid/embracesdk/arch/datasource/DataSourceImpl.kt 100.00% <100.00%> (+5.88%) ⬆️
...droid/embracesdk/arch/datasource/SpanDataSource.kt 100.00% <ø> (ø)
...ndroid/embracesdk/capture/aei/AeiDataSourceImpl.kt 84.46% <100.00%> (ø)
.../embracesdk/capture/crumbs/BreadcrumbDataSource.kt 68.75% <100.00%> (ø)
...cesdk/capture/crumbs/PushNotificationDataSource.kt 88.88% <100.00%> (ø)
...android/embracesdk/capture/crumbs/TapDataSource.kt 75.00% <100.00%> (ø)
.../embracesdk/capture/crumbs/WebViewUrlDataSource.kt 62.50% <100.00%> (ø)
...ure/internal/errors/InternalErrorDataSourceImpl.kt 100.00% <100.00%> (ø)
...bracesdk/capture/memory/MemoryWarningDataSource.kt 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

Base automatically changed from test-common to master July 3, 2024 10:41
@fractalwrench fractalwrench force-pushed the rename-capture-span branch from 188ae78 to 441dcdf Compare July 3, 2024 10:42
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the rename-capture-span branch from 441dcdf to f96cd0e Compare July 3, 2024 15:14
@fractalwrench fractalwrench merged commit b5a8a8f into master Jul 3, 2024
5 checks passed
@fractalwrench fractalwrench deleted the rename-capture-span branch July 3, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants