Prevent eager initialization of data sources #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
data-source-registry
branch
from
0d3fedb to
9e231ca
Compare
fractalwrench
force-pushed
the
avoid-eager-init
branch
from
a2d4de5 to
abc47dd
Compare
fractalwrench
force-pushed
the
data-source-registry
branch
from
9e231ca to
dbddf0a
Compare
fractalwrench
force-pushed
the
avoid-eager-init
branch
from
abc47dd to
02ace01
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 79.75% 79.70% -0.06%
==========================================
Files 416 416
Lines 10775 10776 +1
Branches 1763 1764 +1
==========================================
- Hits 8594 8589 -5
- Misses 1399 1405 +6
Partials 782 782
|
fractalwrench
force-pushed
the
avoid-eager-init
branch
from
02ace01 to
d877205
Compare
fractalwrench
force-pushed
the
avoid-eager-init
branch
from
d877205 to
cb516cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevents the eager initialization of data sources until the
configGateistrueand a session is under way.