Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsafe send error email for EmbraceAutomaticVerification #1049

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Jul 4, 2024

Goal

This isn't used much and has been reported as a security concern

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.70%. Comparing base (e4695b0) to head (7a70e5d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
+ Coverage   79.59%   79.70%   +0.10%     
==========================================
  Files         417      417              
  Lines       10794    10778      -16     
  Branches     1771     1769       -2     
==========================================
- Hits         8592     8591       -1     
+ Misses       1414     1398      -16     
- Partials      788      789       +1     
Files Coverage Δ
...android/embracesdk/EmbraceAutomaticVerification.kt 15.60% <ø> (+1.59%) ⬆️

... and 1 file with indirect coverage changes

@priettt priettt force-pushed the remove-email-intent branch 2 times, most recently from 29e725d to 2fb6cba Compare July 8, 2024 13:40
@priettt priettt marked this pull request as ready for review July 10, 2024 16:19
@priettt priettt requested a review from a team as a code owner July 10, 2024 16:19
@priettt priettt force-pushed the remove-email-intent branch from 2fb6cba to 7a70e5d Compare July 10, 2024 16:19
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priettt priettt merged commit 612354b into master Jul 10, 2024
5 checks passed
@priettt priettt deleted the remove-email-intent branch July 10, 2024 16:52
priettt added a commit that referenced this pull request Jul 10, 2024
priettt added a commit that referenced this pull request Jul 10, 2024
* Remove unsafe send error email for EmbraceAutomaticVerification (#1049)

(cherry picked from commit 612354b)

* Fix missing sdk_version reading it from gradle.properties in kts file (#1072)

(cherry picked from commit e4695b0)

* Use token user and password for Sonatype publishing (#1048)

## Goal
Use token user and password for publishing per [new Maven Central requirements](https://central.sonatype.org/news/20240617_migration_of_accounts/#the-impact-on-ossrh-and-the-central-publisher-portal)

I generated the token user and password per instructions [here](https://central.sonatype.org/publish/generate-token/) and added them to the repo as a secret that I now reference in the workflows, which is this change.

(cherry picked from commit b075f14)

* Consolidate release workflows

---------

Co-authored-by: Nelsito <nelson.puglisi@protonmail.com>
Co-authored-by: Hanson Ho <hanson.ho@embrace.io>
priettt added a commit that referenced this pull request Jul 17, 2024
priettt added a commit that referenced this pull request Jul 17, 2024
* Remove unsafe send error email for EmbraceAutomaticVerification (#1049)

(cherry picked from commit 612354b)

* Update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants