-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsafe send error email for EmbraceAutomaticVerification #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
+ Coverage 79.59% 79.70% +0.10%
==========================================
Files 417 417
Lines 10794 10778 -16
Branches 1771 1769 -2
==========================================
- Hits 8592 8591 -1
+ Misses 1414 1398 -16
- Partials 788 789 +1
|
priettt
force-pushed
the
remove-email-intent
branch
2 times, most recently
from
July 8, 2024 13:40
29e725d
to
2fb6cba
Compare
priettt
force-pushed
the
remove-email-intent
branch
from
July 10, 2024 16:19
2fb6cba
to
7a70e5d
Compare
bidetofevil
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
priettt
added a commit
that referenced
this pull request
Jul 10, 2024
(cherry picked from commit 612354b)
priettt
added a commit
that referenced
this pull request
Jul 10, 2024
* Remove unsafe send error email for EmbraceAutomaticVerification (#1049) (cherry picked from commit 612354b) * Fix missing sdk_version reading it from gradle.properties in kts file (#1072) (cherry picked from commit e4695b0) * Use token user and password for Sonatype publishing (#1048) ## Goal Use token user and password for publishing per [new Maven Central requirements](https://central.sonatype.org/news/20240617_migration_of_accounts/#the-impact-on-ossrh-and-the-central-publisher-portal) I generated the token user and password per instructions [here](https://central.sonatype.org/publish/generate-token/) and added them to the repo as a secret that I now reference in the workflows, which is this change. (cherry picked from commit b075f14) * Consolidate release workflows --------- Co-authored-by: Nelsito <nelson.puglisi@protonmail.com> Co-authored-by: Hanson Ho <hanson.ho@embrace.io>
priettt
added a commit
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 612354b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This isn't used much and has been reported as a security concern