Support async init of features #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1053 +/- ##
=======================================
Coverage 79.70% 79.71%
=======================================
Files 416 416
Lines 10776 10786 +10
Branches 1764 1766 +2
=======================================
+ Hits 8589 8598 +9
+ Misses 1405 1404 -1
- Partials 782 784 +2
|
bidetofevil
approved these changes
Jul 8, 2024
fractalwrench
force-pushed
the
avoid-eager-init
branch
2 times, most recently
from
d877205 to
cb516cb
Compare
fractalwrench
force-pushed
the
poc-async-feature-init
branch
from
3adaa47 to
f74be1c
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Supports the async initialization of features in Embrace. While this changeset does not alter any feature to be initialized async it creates the infrastructure to do so.
Testing
Added unit test coverage.