Create interface for internal apis #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
requested review from
fnewberg,
bidetofevil and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
+ Coverage 79.65% 79.75% +0.10%
==========================================
Files 417 417
Lines 10788 10788
Branches 1770 1770
==========================================
+ Hits 8593 8604 +11
+ Misses 1407 1397 -10
+ Partials 788 787 -1
|
fractalwrench
force-pushed
the
add-new-modules
branch
from
d4b8c77 to
ff40d0c
Compare
fractalwrench
force-pushed
the
internal-interface-api
branch
from
e1cb0e3 to
e596c82
Compare
fractalwrench
force-pushed
the
internal-interface-api
branch
from
e596c82 to
d19d361
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
fractalwrench
force-pushed
the
internal-interface-api
branch
from
d19d361 to
98c866f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Creates an interface that is used for accessing the unity/flutter/react native internal interfaces. This change will ultimately make it easier to create a shim interface around
Embrace/EmbraceImpl