Preparatory refactor for making EmbraceImpl an interface #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
requested review from
fnewberg,
bidetofevil and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
- Coverage 79.65% 79.64% -0.01%
==========================================
Files 417 417
Lines 10788 10788
Branches 1770 1770
==========================================
- Hits 8593 8592 -1
- Misses 1407 1408 +1
Partials 788 788
|
bidetofevil
reviewed
Jul 8, 2024
| @@ -15,7 +15,7 @@ public interface NetworkRequestApi { | |||
| */ | |||
| public fun recordNetworkRequest(networkRequest: EmbraceNetworkRequest) | |||
|
|
|||
| public fun getTraceIdHeader(): String | |||
| public val traceIdHeader: String | |||
There was a problem hiding this comment.
Given that we have NSF as well as OTel stuff to consider, this naming is pretty problematic.
We shouldn't change it in this PR, but we should probably change this when we bump our SDK version to 7.0
fractalwrench
force-pushed
the
internal-interface-api
branch
3 times, most recently
from
d19d361 to
98c866f
Compare
fractalwrench
force-pushed
the
interface-refactor
branch
from
c1051b3 to
592e140
Compare
fractalwrench
force-pushed
the
interface-refactor
branch
from
592e140 to
2b2b448
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Preparatory refactor that will make it easier to create an interface out of
EmbraceImpl, which will make modularisation possible.