Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide embrace impl behind interface #1061

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Creates an interface for EmbraceImpl. This will allow us to set the embrace implementation on the facade without directly referencing it.

@fractalwrench fractalwrench requested review from fnewberg, bidetofevil and a team as code owners July 8, 2024 10:52
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (38b6cb5) to head (c789e7f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
- Coverage   79.64%   79.59%   -0.05%     
==========================================
  Files         417      417              
  Lines       10788    10794       +6     
  Branches     1770     1771       +1     
==========================================
  Hits         8592     8592              
- Misses       1408     1414       +6     
  Partials      788      788              
Files Coverage Δ
.../android/embracesdk/injection/InjectEmbraceImpl.kt 100.00% <100.00%> (ø)
...ernal/api/delegate/FlutterInternalInterfaceImpl.kt 91.66% <66.66%> (ø)
...cesdk/internal/api/delegate/SdkStateApiDelegate.kt 70.00% <66.66%> (ø)
...nternal/api/delegate/UnityInternalInterfaceImpl.kt 44.23% <50.00%> (ø)
...in/java/io/embrace/android/embracesdk/Embrace.java 81.43% <0.00%> (-0.99%) ⬇️
...l/api/delegate/ReactNativeInternalInterfaceImpl.kt 65.85% <66.66%> (ø)
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt 76.56% <0.00%> (-2.47%) ⬇️

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the embrace-impl-refactor branch from 67be8c8 to b65a4c3 Compare July 9, 2024 10:09
@fractalwrench fractalwrench force-pushed the embrace-impl-refactor branch 2 times, most recently from f811f72 to 1064de2 Compare July 9, 2024 10:18
Base automatically changed from interface-refactor to master July 9, 2024 11:39
@fractalwrench fractalwrench force-pushed the embrace-impl-refactor branch from 1064de2 to c789e7f Compare July 9, 2024 11:39
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@fractalwrench fractalwrench merged commit d1f4040 into master Jul 9, 2024
4 of 5 checks passed
@fractalwrench fractalwrench deleted the embrace-impl-refactor branch July 9, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants