Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting app framework via embrace-config.json #1064

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds the option to set the AppFramework via embrace-config.json and makes this the preferred method of doing so. The old way of setting AppFramework via Embrace.getInstance.start(context, AppFramework) is still supported for now. embrace-config.json takes precedence, then anything supplied in the start function, followed by the SDK default of AppFramework.NATIVE.

Testing

Added unit test coverage.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@fractalwrench fractalwrench force-pushed the app-framework-alternative branch 2 times, most recently from 4dbff8b to dc442d4 Compare July 8, 2024 15:52
@fractalwrench fractalwrench marked this pull request as ready for review July 8, 2024 15:52
@fractalwrench fractalwrench requested review from fnewberg, bidetofevil and a team as code owners July 8, 2024 15:52
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The idea is then to have all folks just older versions to add the appropriate value in the config file eventually? We can probably do this as part of the bump to 7.0

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 72.58065% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@cc3d2c8). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1064   +/-   ##
=========================================
  Coverage          ?   79.65%           
=========================================
  Files             ?      417           
  Lines             ?    10788           
  Branches          ?     1770           
=========================================
  Hits              ?     8593           
  Misses            ?     1407           
  Partials          ?      788           
Files Coverage Δ
...re/envelope/resource/EnvelopeResourceSourceImpl.kt 96.42% <100.00%> (ø)
...racesdk/capture/metadata/EmbraceMetadataService.kt 84.95% <100.00%> (ø)
...mbracesdk/capture/metadata/HostedSdkVersionInfo.kt 88.23% <100.00%> (ø)
...oid/embracesdk/capture/metadata/MetadataService.kt 100.00% <ø> (ø)
.../android/embracesdk/config/local/SdkLocalConfig.kt 100.00% <100.00%> (ø)
...embrace/android/embracesdk/injection/CoreModule.kt 66.66% <ø> (ø)
.../android/embracesdk/injection/CustomerLogModule.kt 92.30% <ø> (ø)
...id/embracesdk/injection/InternalInterfaceModule.kt 100.00% <ø> (ø)
...race/android/embracesdk/injection/PayloadModule.kt 100.00% <100.00%> (ø)
...l/api/delegate/ReactNativeInternalInterfaceImpl.kt 65.85% <ø> (ø)
... and 13 more

@fractalwrench
Copy link
Contributor Author

Yep, that's the idea. We can add instructions in the changelog for the next release, and the migration guide for 7

@fractalwrench fractalwrench force-pushed the app-framework-alternative branch from dc442d4 to 7dfb5d1 Compare July 9, 2024 09:19
@fractalwrench fractalwrench merged commit 5c6b6a4 into master Jul 9, 2024
5 checks passed
@fractalwrench fractalwrench deleted the app-framework-alternative branch July 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants