Allow setting app framework via embrace-config.json #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the option to set the AppFramework via embrace-config.json and makes this the preferred method of doing so. The old way of setting AppFramework via
Embrace.getInstance.start(context, AppFramework)
is still supported for now.embrace-config.json
takes precedence, then anything supplied in thestart
function, followed by the SDK default ofAppFramework.NATIVE
.Testing
Added unit test coverage.