Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic verification from EmbraceSamples #1066

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Jul 8, 2024

Goal

Automatic verification is seldom used, and it causes a bit of confusion, as some customers are actually keeping it on release builds. This PR removes it altogether.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@92d840a). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1066   +/-   ##
=========================================
  Coverage          ?   82.90%           
=========================================
  Files             ?      433           
  Lines             ?    11278           
  Branches          ?     1755           
=========================================
  Hits              ?     9350           
  Misses            ?     1147           
  Partials          ?      781           
Files Coverage Δ
...va/io/embrace/android/embracesdk/EmbraceSamples.kt 0.00% <ø> (ø)
...d/embracesdk/internal/injection/CrashModuleImpl.kt 100.00% <ø> (ø)
...cesdk/internal/injection/ModuleInitBootstrapper.kt 88.02% <ø> (ø)

@priettt priettt marked this pull request as ready for review July 10, 2024 16:15
@priettt priettt force-pushed the remove-verification branch from 21817c8 to ee746b1 Compare July 10, 2024 16:15
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this require the UI to be updated? If so, we may not want to do this quite yet - we can remove the email thing, cherrypick that, and then do this so it gives the UI folks more time to change the integration flow.

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should not merge this until UI changes to our dash are deployed. Can you coordinate those changes with the relevant folks (if you haven't already)?

@priettt priettt force-pushed the remove-verification branch from ee746b1 to e7893e3 Compare July 24, 2024 19:40
@priettt priettt force-pushed the remove-verification branch from e7893e3 to 96de665 Compare July 25, 2024 16:28
@priettt priettt merged commit 5912869 into master Jul 26, 2024
5 of 6 checks passed
@priettt priettt deleted the remove-verification branch July 26, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants