Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip URL of network request of parameters #1080

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jul 11, 2024

Goal

Strip the URL for logged network requests so it doesn't contain URL parameters that take up space and may trigger the attribute to be dropped

Copy link
Contributor

github-actions bot commented Jul 11, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

@bidetofevil bidetofevil force-pushed the hho/strip-network-request branch from cb9a840 to fedc553 Compare July 11, 2024 23:11
@bidetofevil bidetofevil marked this pull request as ready for review July 11, 2024 23:25
@bidetofevil bidetofevil requested a review from a team as a code owner July 11, 2024 23:25
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (09f28d3) to head (fedc553).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1080   +/-   ##
=======================================
  Coverage   79.72%   79.73%           
=======================================
  Files         417      417           
  Lines       10778    10778           
  Branches     1769     1769           
=======================================
+ Hits         8593     8594    +1     
  Misses       1397     1397           
+ Partials      788      787    -1     
Files Coverage Δ
...brace/android/embracesdk/arch/schema/SchemaType.kt 81.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@bidetofevil bidetofevil merged commit 2b52837 into master Jul 12, 2024
5 checks passed
@bidetofevil bidetofevil deleted the hho/strip-network-request branch July 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants