Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress unwanted docs #1081

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Suppresses unwanted symbols that are internal-only from our KDoc. @hide should not be used - @supress should be used instead. Anything inside an internal.** package is automatically hidden by our Dokka setup.

This hides the vast majority of unwanted symbols. We may want to convert some Java classes as part of the major bump to have a mechanism for hiding them (and also get rid of Java code).

@fractalwrench fractalwrench requested a review from a team as a code owner July 12, 2024 09:41
Base automatically changed from internal-api-visibility to master July 12, 2024 09:42
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Is there a way to get dokka to understand @InternalApi so we can kill two birds with that stone?

@fractalwrench fractalwrench changed the base branch from master to feature-api-visibility July 16, 2024 09:45
@fractalwrench fractalwrench force-pushed the suppress-unwanted-docs branch from a0bc3f0 to f5427b4 Compare July 16, 2024 09:47
@fractalwrench
Copy link
Contributor Author

There isn't a way to get Dokka to understand arbitrary annotations as far as I can see unfortunately. However, given that we're moving most of the internal classes to other modules eventually this should be a much smaller problem in future.

@fractalwrench fractalwrench merged commit 46c93ba into feature-api-visibility Jul 16, 2024
1 check passed
@fractalwrench fractalwrench deleted the suppress-unwanted-docs branch July 16, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants